This is really a great theme which not only changes the layout, but also helps a lot to structure the Wiki. The only thing I would wish is that it could handle CategoryCategory and recursions caused by the FullSearch macro, because these come with the standard installation. I have read through the /CategorizingBestPractices page, but I find it not very practical to eliminate CategoryCategory or the macro that automatically lists all category pages. Maybe the macro can be improved to not list the current page? I also have still a problem with my main categories (of CategoryRoot) which are displayed in the [Orphaned] subtree as well as in the root tree. -- AnkeHeinrich 2007-10-08

• I agree, Anke, that the recursions in the category tree caused by some macros (as in CategoryCategory) should be solved. From my point of view this is conceptual error in MoinMoin. I planned to post a feature request for changing this behavior. MoinMoin determines the categories a page belongs to by retrieving all links to category pages from the given page. When doing so the macros are executed. If the resulting content of the macro generates a link to a category, the page will automatically belong to that category. I think that generally the user doesn't intend this when adding a macro to a page. This behavior didn't matter so far as the default themes don't make use of categories. Until this behavior is changed in MoinMoin macros that generate category links should be used with care.

  The main categories should obviously not appear in the [Orphaned] subtree. This didn't happen to me in any of the wikis. Please provide me some additional information to investigate this: especially the explorer_root and page_category_regex values if set and maybe the content of any of these main categories. Have you also created the RootCategory? What is it's content? -- WolfgangFischer 2007-10-13 17:39:38

  • I have described more details in /Bugs/MainCategoriesDisplayedInRootAndOrphanedFolder. -- AnkeHeinrich 2007-10-14 15:00:23

    I have modified my FullSearch macro to contain the following lines after the results have been searched:

    tmp = dict([(hit.page_name, hit) for hit in results.hits])
    if tmp.has_key(macro.formatter.page.page_name):
        del tmp[macro.formatter.page.page_name]
    results.hits = [item[1] for item in tmp.items()]

    This removes the current page from the list, so the macro FullSearch is usuable with the explorer theme. However, the CategoryCategory page that comes with MoinMoin still contains a list of all existing categories which leads to recursions in the explorer theme -- AnkeHeinrich 2007-10-14 19:31:39

Solution

Thank you very much, Anke, for stressing the need of a solution. I found a simple solution to this problem. However, as this behavior is related to MoinMoin, I have posted a bug report asking for a fix (see MoinMoinBugs/MacrosCategorizePages). Perhaps the proposed solution will help you until the problem gets fixed in MoinMoin. The solution also makes your above mentioned patch obsolete

• Wolfgang, I've tried the proposed solution, but for some reason it does not completely solve the issue. I'm still getting recursions related to CategoryCategory and CategoryHomePage, e.g. in [System] folder. It fixes the same issues as my patch, but not all. -- AnkeHeinrich 2007-10-15 15:17:29

  • Please provide some additional information, Anke. What is exactly the structure of these remaining recursions? -- WolfgangFischer 2007-10-16 05:28:43

    • It must have been a caching problem, since the recursions are gone now. The only little confusion left is that CategoryHomepage is displayed twice in the [System] tree (see picture). -- AnkeHeinrich 2007-10-16 11:48:00
      

      • Thank you for your help, Anke! "The only little confusion left" is now fixed in releases 1.0.2 resp. 1.1beta3. -- WolfgangFischer 2007-10-16 14:04:43

Update

There is a workaround included in release 2.0beta. There is no need to patch the pagelinks formatter any more. -- WolfgangFischer 2007-11-09 14:34:41